Skip to content

Fix WHITEPAPER_AUDIT.md notation, clarifications, and terminology#34

Merged
Steake merged 2 commits intofeature/economic-system-and-rewardsfrom
copilot/sub-pr-31
Dec 6, 2025
Merged

Fix WHITEPAPER_AUDIT.md notation, clarifications, and terminology#34
Steake merged 2 commits intofeature/economic-system-and-rewardsfrom
copilot/sub-pr-31

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 6, 2025

Addresses review feedback on the whitepaper audit document to improve technical accuracy and consistency.

Notation fixes:

  • Trust Calculation: Changed R = r_m + s_m to W = r_m + s_m (standard EBSL notation), added parentheses: belief = r_m / (W+K)
  • Decay mechanism: Use consistent variable names r_m and s_m instead of R and S

Clarifications added:

  • Winner ID validation: Documented that w*(w-1)*(w-2)=0 constraint means 0 = Player A wins, 1 = Player B wins, 2 = Draw
  • Privacy Premium: Clarified 2x gas multiplier applies to Ring Signature Privacy

Terminology standardization:

  • Changed all instances of "SNARK" to "zkSNARK" throughout document (lines 911, 913, 918, 971)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…dize terminology

Co-authored-by: Steake <530040+Steake@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comprehensive audit document for economic system and rewards Fix WHITEPAPER_AUDIT.md notation, clarifications, and terminology Dec 6, 2025
Copilot AI requested a review from Steake December 6, 2025 10:08
@Steake Steake marked this pull request as ready for review December 6, 2025 10:56
Copilot AI review requested due to automatic review settings December 6, 2025 10:56
@Steake Steake merged commit 214a0cb into feature/economic-system-and-rewards Dec 6, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the technical accuracy and consistency of the WHITEPAPER_AUDIT.md document by correcting mathematical notation, adding clarifications, and standardizing terminology to align with established conventions and the actual codebase implementation.

Key changes:

  • Fixed EBSL trust calculation notation to use standard W for weight of evidence and added parentheses for clarity
  • Standardized terminology from "SNARK" to "zkSNARK" throughout the document (4 occurrences)
  • Added helpful clarifications for winner ID validation and privacy premium features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants